这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@3onyc
Copy link
Contributor

@3onyc 3onyc commented Apr 14, 2015

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should probably be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@michaelshobbs
Copy link
Member

This was (loosely) intentionally called in the same manner as buildstep deploys to maintain a similar execution path. Can you provide your use case that requires this change?

@3onyc 3onyc force-pushed the bug-pre-build-dockerfile-hook branch from d29f64d to bc8750e Compare April 14, 2015 18:46
@3onyc
Copy link
Contributor Author

3onyc commented Apr 14, 2015

I don't have an example use-case right now as I noticed this while reading the code.

However, looking at the logic for buildstep, the actual build is triggered after the pre-build* hooks.

@michaelshobbs
Copy link
Member

Hm. I'm clearly not recalling correctly. Seems legit to me then.

@michaelshobbs
Copy link
Member

@josegonzalez: what do you think here?

Dockerfile deployments are brand new for dokku and I don't think there are any dockerfile-specific plugins yet. I was hoping to feedback on this workflow as folks started to use it. In any case, as this is early days making this particular change is probably semantically correct at the least. 😄

@josegonzalez
Copy link
Member

Seems legit to me.

josegonzalez added a commit that referenced this pull request Apr 14, 2015
Call pre-build-dockerfile before docker build
@josegonzalez josegonzalez merged commit 5224a6c into dokku:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants