这是indexloc提供的服务，不要输入任何密码
Skip to content

Make port forwarding configurable #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2015
Merged

Make port forwarding configurable #1084

merged 1 commit into from
Apr 3, 2015

Conversation

@awendt
Copy link
Contributor

@awendt awendt commented Apr 2, 2015

My first attempt to build the Vagrant VM resulted in this error:

Vagrant cannot forward the specified ports on this VM, since they
would collide with some other application that is already listening
on these ports. The forwarded port to 8080 is already in use
on the host machine.

because I already had another VM listening on 8080.

This change enables devs to avoid port collisions by specifying:

FORWARDED_PORT=8091 vagrant up

@josegonzalez
Copy link
Member

josegonzalez commented Apr 3, 2015

Seems legit.

josegonzalez added a commit that referenced this pull request Apr 3, 2015
@josegonzalez
Merge pull request #1084 from awendt/avoid-port-collisions
6ac59dc 
Make port forwarding configurable
@josegonzalez josegonzalez merged commit 6ac59dc into dokku:master Apr 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@awendt @josegonzalez