Fix URL schemes in dokku urls output
#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/nginx-vhosts/commands
Outdated
Member
There was a problem hiding this comment.
Do we need the extra output? If so, you should use the helper in common for this :)
Contributor
Author
There was a problem hiding this comment.
Not really needed no, dropped.
Previously, the presence of TLS certificates would cause `dokku urls` to output all https URLs, even for domains which were not configured to use TLS. This change introduces a URLS file in the app's directory which contains the URLs with schemes based on whether they have been configured to use TLS in the nginx config. Signed-off-by: Lewis Marshall <lewis@lmars.net>
Member
|
In reference to my comment on #1008, perhaps we can write a test that ensures we don't return |
Contributor
Author
|
@michaelshobbs I have fixed the sub-subdomain match issue in #1008 |
michaelshobbs
added a commit
that referenced
this pull request
Mar 9, 2015
Fix URL schemes in `dokku urls` output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the presence of TLS certificates would cause
dokku urlsto output all https URLs, even for domains which were not configured to use TLS.This change introduces a URLS file in the app's directory which contains the URLs with schemes based on whether they have been configured to use TLS in the nginx config.