remove quoting from dockerfile env. closes #1002 #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why the link? |
Member
Author
|
This allows the app env to be included in containers started with |
|
@michaelshobbs Thanks for both fixes. That with the link would have been my next issue. 👍 |
Member
Author
|
tests are failing. i'll need to dig into that |
|
Is this why my Dockerfile ENV variables have quotes around them, but the buildpack ones don't? |
Member
Author
|
Probably, yes. 😄 |
|
What is holding up the merge of this? Looks like tests pass according to CircleCI |
Member
Author
|
Was hoping for more comments I suppose. I'll merge now. |
michaelshobbs
added a commit
that referenced
this pull request
Mar 6, 2015
remove quoting from dockerfile env. closes #1002
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCKERFILE_ENV_FILE