trigger docker-args-build for dockerfile deployments #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
added a commit
that referenced
this pull request
Oct 22, 2015
…ker-args-build trigger docker-args-build for dockerfile deployments
|
Hello I have noticed that eg. official mongo plugin creates a https://github.com/dokku/dokku-mongo/blob/master/functions#L92 So when I try to push changes I see this:
So I think after this PR plugins should reconsider their build flags since they does matter now. Or am I doing something wrong? |
Member
Author
|
related: #1609 |
|
@michaelshobbs thanks. I've missed that issue. That seems to be it, indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1588