这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Flink
Copy link
Contributor

@Flink Flink commented Sep 21, 2015

This way we won’t have a list of plugins with a lot of dokku-* in their names.

@michaelshobbs
Copy link
Member

I totally get the reasoning here but I'm not sure we want to 'magically' modify names of plugins. I'm curious if anybody else has thoughts on this.

(To be clear: I don't think I personally care but I'd like to hear what other users think before merging this in)

@hhff
Copy link
Contributor

hhff commented Sep 21, 2015

jah i tend to agree - with such a large mass of bash scripting I think we'd want to keep the "magic" to a minimum

@josegonzalez
Copy link
Member

You could ask people for confirmation and respect the --force flag.

@Flink
Copy link
Contributor Author

Flink commented Sep 21, 2015

@josegonzalez ask for confirmation of installation without the dokku- part? What the --force flag will do?

@josegonzalez
Copy link
Member

A few things:

  • We should be able to specify the plugin name.
  • If we detect a dokku- prefix, we should ask the user to confirm that they want to remove it.
  • If the user does dokku --force plugin:install whatever, then it will remove the prefix without prompting the user.

@Flink
Copy link
Contributor Author

Flink commented Sep 21, 2015

Ok so plugin:install should accept a second argument that specify the local name of the plugin to be installed, right?
If user provides this second argument, do we strip the dokku- prefix if it has it? I think we shouldn’t in this case.
And then --force should do nothing when user provide the second argument in this case.

@josegonzalez
Copy link
Member

We don't strip if they provide a name.

@michaelshobbs
Copy link
Member

I'd prefer if we didn't prompt by default. Sounds annoying

@josegonzalez
Copy link
Member

Okay, fine by me, strip by default unless someone forces a name.

@Flink
Copy link
Contributor Author

Flink commented Sep 22, 2015

Ok, so --force is not needed anymore then :)

@Flink
Copy link
Contributor Author

Flink commented Sep 22, 2015

Updated :)

@josegonzalez
Copy link
Member

Seems legit!

josegonzalez added a commit that referenced this pull request Sep 23, 2015
Strip the `dokku-` part from plugins on install
@josegonzalez josegonzalez merged commit 1aee4fd into dokku:master Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants