-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Strip the dokku- part from plugins on install
#1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I totally get the reasoning here but I'm not sure we want to 'magically' modify names of plugins. I'm curious if anybody else has thoughts on this. (To be clear: I don't think I personally care but I'd like to hear what other users think before merging this in) |
|
jah i tend to agree - with such a large mass of bash scripting I think we'd want to keep the "magic" to a minimum |
|
You could ask people for confirmation and respect the |
|
@josegonzalez ask for confirmation of installation without the |
|
A few things:
|
|
Ok so |
|
We don't strip if they provide a name. |
|
I'd prefer if we didn't prompt by default. Sounds annoying |
|
Okay, fine by me, strip by default unless someone forces a name. |
|
Ok, so |
|
Updated :) |
|
Seems legit! |
Strip the `dokku-` part from plugins on install
This way we won’t have a list of plugins with a lot of
dokku-*in their names.