这是indexloc提供的服务，不要输入任何密码
Skip to content

Properly detect app name in the official cli client #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2015
Merged

Properly detect app name in the official cli client #1447

merged 2 commits into from
Sep 10, 2015

Conversation

@alanjds
Copy link
Contributor

@alanjds alanjds commented Sep 8, 2015

Before the fix, the "most official" command line tool was detecting all my repos with "dokku" as the appname

@josegonzalez
Copy link
Member

josegonzalez commented Sep 8, 2015

Looks like this change broke the client tests. What do your remotes look like?

@alanjds
Copy link
Contributor Author

alanjds commented Sep 8, 2015

Follows my remotes.

airpill:apiregistro (master) alanjds$ uname -a
Darwin airpill 13.4.0 Darwin Kernel Version 13.4.0: Wed Mar 18 16:20:14 PDT 2015; root:xnu-2422.115.14~1/RELEASE_X86_64 x86_64
airpill:apiregistro (master) alanjds$ git --version
git version 1.9.3 (Apple Git-50)
airpill:apiregistro (master) alanjds$ git remote -v
deis    git@deis-01c.mydomain.com.br:hungry-universe.git (push)
deis    git@deis-01c.mydomain.com.br:hungry-universe.git (fetch)
dokku   dokku@dk-01.mydomain.com.br:apiregistro (push)
dokku   dokku@dk-01.mydomain.com.br:apiregistro (fetch)
heroku  git@heroku.com:apiregistro.git (fetch)
heroku  git@heroku.com:apiregistro.git (push)
stag    git@heroku.com:apiregistro-stag.git (push)
stag    git@heroku.com:apiregistro-stag.git (fetch)
airpill:apiregistro (master) alanjds$

And:

airpill:apiregistro (master) alanjds$ git remote -v 2>/dev/null | grep -Ei "dokku@$DOKKU_HOST" | head -n 1 | cut -f1 -d' ' | cut -f2 -d':' 2>/dev/null
dokku   dokku@dk-01.mydomain.com.br
airpill:apiregistro (master) alanjds$ git remote -v 2>/dev/null | grep -Ei "dokku@$DOKKU_HOST" | head -n 1 | cut -f1 -d' ' | cut -f3 -d':' 2>/dev/null
apiregistro

@josegonzalez
Copy link
Member

josegonzalez commented Sep 8, 2015

How about instead it could be:

git remote -v 2>/dev/null | grep -Ei "dokku@$DOKKU_HOST" | head -n 1 | cut -f2 -d'@' | cut -f1 -d' ' | cut -f2 -d':' 2>/dev/null

That would cover both your case and the existing case I think.

@alanjds
Copy link
Contributor Author

alanjds commented Sep 10, 2015

Is there. Waiting for Travis bless. Just realized that CircleCI is on the loop. I got confused. Anyway...

@josegonzalez
Copy link
Member

josegonzalez commented Sep 10, 2015

We don't test via travis (if it's still enabled, ignore it).

@josegonzalez
Copy link
Member

josegonzalez commented Sep 10, 2015

Awesome, does this work for you?

josegonzalez added a commit that referenced this pull request Sep 10, 2015
@josegonzalez
Merge pull request #1447 from alanjds/fix-appname-detection
1b5756c 
Fix: appname was not correctly detected
@josegonzalez josegonzalez merged commit 1b5756c into dokku:master Sep 10, 2015
@alanjds
Copy link
Contributor Author

alanjds commented Sep 10, 2015

Yes. It works. Thanks

@josegonzalez josegonzalez changed the title Fix: appname was not correctly detected Properly detect app name in the official cli client Sep 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alanjds @josegonzalez