这是indexloc提供的服务，不要输入任何密码
Skip to content

Create CONTRIBUTING.md #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2015
Merged

Create CONTRIBUTING.md #1445

merged 1 commit into from
Sep 15, 2015

Conversation

@josegonzalez
Copy link
Member

@josegonzalez josegonzalez commented Sep 7, 2015

Closes #1435

@josegonzalez
Copy link
Member Author

josegonzalez commented Sep 8, 2015

I think we can start here and iterate as we see what works?

@Flink
Copy link
Contributor

Flink commented Sep 9, 2015

From https://github.com/docker/docker/blob/master/CONTRIBUTING.md#quick-contribution-tips-and-guidelines there’s also a little section on git and I think we should incite good practices when writing commits like using rebase, squash commits, etc. (starting with us ;))

michaelshobbs
michaelshobbs reviewed Sep 10, 2015
View reviewed changes
CONTRIBUTING.md Outdated
Copy link
Member

@michaelshobbs michaelshobbs Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

branche?

Copy link
Contributor

@Flink Flink Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that’s french for branch 😁

@michaelshobbs
Copy link
Member

michaelshobbs commented Sep 10, 2015

👍 on @Flink's comment

@josegonzalez
Create CONTRIBUTING.md
1c48c9c 
Closes #1435

[ci skip]
@josegonzalez
Copy link
Member Author

josegonzalez commented Sep 15, 2015

Updated the Making Changes section to take @Flink's comment into account. Merging :)

josegonzalez added a commit that referenced this pull request Sep 15, 2015
@josegonzalez
Merge pull request #1445 from progrium/1435-josegonzalez
2ba9809 
Create CONTRIBUTING.md
@josegonzalez josegonzalez merged commit 2ba9809 into master Sep 15, 2015
@josegonzalez josegonzalez deleted the 1435-josegonzalez branch September 15, 2015 03:44
@Flink
Copy link
Contributor

Flink commented Sep 15, 2015

Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josegonzalez @Flink @michaelshobbs