Use $PLUGIN_PATH instead of $(dirname $0)/..
#1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As briefly discussed in dokku#1425, source the `common/functions` file via an absolute path, rather than determining the relative path by using `dirname`. 3rd-party plugins should follow suit and use the new `$PLUGIN_PATH` convention too.
Contributor
|
That was quick! 😄 I think you should also update the documentation to reflect these changes. |
Contributor
Author
|
Done, apparently my |
Contributor
|
👍 |
josegonzalez
added a commit
that referenced
this pull request
Aug 28, 2015
Use `$PLUGIN_PATH` instead of `$(dirname $0)/..`
This was referenced Aug 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed in #1425, source the
common/functionsfile via an absolute path, rather than determining the relative path by usingdirname. 3rd-party plugins should follow suit and use the new$PLUGIN_PATHconvention too.I only had a few minutes of spare time to put this together, so I haven't run tests locally, and instead will be relying on the PR CI stuff to do it for me :)