I don't understand the help dialog change. Can you explain that a bit more?

Happy to. If you read it literally, just like a brand new user may, it asks you (in quotes) to type 'dokku help'.

Here's a sample interaction before PR:

foo
 !    `foo` is not a dokku command.
 !    See `dokku help` for a list of available commands.
dokku help
 !    `dokku help` is not a dokku command.
 !    See `dokku help` for a list of available commands.

😦
After:

foo
 !    `foo` is not a dokku command.
 !    See `help` for a list of available commands.
help
Usage: dokku [--quiet|--trace|--rm-container|--rm|--force] COMMAND <app> [command-specific-options]

Options:
    apps:cre...

😄

Wait, are you inside of dokku shell?

Correct, aka $ dokku shell (or ssh dokku@dokku.me shell).

I edited my example above to clarify.

I think the expectation is that once you are in a dokku shell, you don't need to use the prefix anymore. Can you revert that change in your PR (and squash the commits)?

You can open a second PR adding custom MOTD - telling people to not prefix dokku commands - for dokku shell, which will probably be much more useful than this change. There are other places where we call out the dokku command in help output, so ^ would cover it.

np, just pushed up the change.

Wait, why did you get a tty error before? Note: I don't seem to have such an error on master. Can you paste the command that results in an error?

Here you go:

$ ssh dokku@dokku.me ps node-js-app
time="2015-08-26T21:58:25Z" level=fatal msg="cannot enable tty mode on non tty input" 

Do you have RequestTTY yes in your ssh config? http://progrium.viewdocs.io/dokku/remote-commands/

If so, you may not see this bug. Because that line is buried in the documentation, this brings up a new question: Should we just bubble up this documentation since this would be bug is probably lurking in other sub-commands in Dokku or should we fix the TTY bugs (since there is an easy function for it already) when we find them?

Here is my .ssh/config:

Host *
  CheckHostIP yes
  ControlMaster auto
  ControlPath ~/.ssh/master-%r@%h:%p
  SendEnv LANG LC_*
  HashKnownHosts yes
  GSSAPIAuthentication no
  GSSAPIDelegateCredentials no
  RSAAuthentication yes
  PasswordAuthentication yes
  StrictHostKeyChecking no

Hmm somewhere that's being set. Try disabling it with -T, my patch allows you to execute without the pseudo-tty:

$ ssh -T dokku@dokku.me ps node-js-app

Maybe it's because I'm using contrib/dokku_client.sh? Can you try with that?

Given the variance in how different folks might have configured their SSH clients, I like the idea of using has_tty where it makes sense.

Also contrib/dokku_client.sh forces -t

https://github.com/progrium/dokku/blob/ebfcece6200a19dcef5dda79f030f704813d289e/contrib/dokku_client.sh#L97
https://github.com/progrium/dokku/blob/ebfcece6200a19dcef5dda79f030f704813d289e/contrib/dokku_client.sh#L124

@michaelshobbs I haven't read up about the flag just yet, but if you feel comfortable merging, ship it :)

Full disclosure, @u2mejc sits right next to me at work. @u2mejc did you test this change with the dokku_client? If not, would you please? It's probably fine but just want to make sure we don't have some weirdness there.

@michaelshobbs is correct. This patch removes the requirement.

NAME
     ssh -- OpenSSH SSH client (remote login program)
...
     -T      Disable pseudo-tty allocation.

     -t      Force pseudo-tty allocation.  This can be used to execute arbitrary screen-based programs on a remote machine, which can be very useful, e.g. when implementing menu services.  Multiple -t options force tty allocation, even if ssh has no local tty.

Yep, I tested dokku_client.sh and it does work with or without the patch.

@u2mejc good work! Mind making a PR to add MOTD support to dokku shell?