-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add links to official dokku datastorage plugins #1408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@josegonzalez Great work it seems! :) There is a typo in your comment, the Postgres link points to the redis plugin. So about community plugins, what does this mean exactly? I suppose they will be deprecated when those plugins won’t be in beta anymore? |
[ci skip]
|
Fixed the typo. I think that we should probably combine forces. If a community plugin maintainer wants to step up and help out with a particular plugin, then I'm all ears. If a developer wants to maintain their own, thats fine too. The beta thing is there so that people don't instantly flock to them when they have working installations with the existing plugins. |
|
If any existing maintainer would like to join the team for a plugin they currently maintain, let me know and I will add you. I'd like to reduce the amount of work the you all are doing and provide a great experience for our community :) (@Flink I added you to the plugins) |
|
@josegonzalez thanks, I just joined! 😁 How do we proceed? |
|
If you'd like to prototype any of the two remaining tasks on one of the plugins, that would be great. I can do the service writeup. Once that's all done, we merge this branch and are off to the races :) |
|
Ok great. I’ll have to read/understand your code first so I won’t break anything 😁 |
|
@josegonzalez love it man. I was just having the conversation about "official" datastore plugins on Friday with one of the Ops guys here. |
|
Great work! I am really excited to have an official, supported plugin. I maintain one of the mongo and postgresql ones and I don't use them much anymore so it will be really great to have officially supported ones that have more eyes on them. I would be glad to help maintain the official mongo and postgres ones. I can review code and partake in discussions. However, I don't think I will be using them enough to contribute much code. |
|
Thanks! Also, from skimming the docs and the code. It looks like the official plugins support both |
|
That is correct. Usage of the plugins is totally up to the user installing them. I hope that we stick to this for any further plugins, and that the only thing we do is allow users to easily customize their services :) |
|
Labeling this as |
|
@josegonzalez Nice :D I'm guessing you would like us to put a redirect to the official dokku plugins for "combining forces"? I would be happy to contribute and provide feedback to the official repos, but I can't say I use it much anymore. |
|
This is so great |
|
@sekjun9878 potentially. Once they get merged in, I would, though that's up to you :) I'll add you to the repos when I'm in my office. |
|
I think the plugins are currently in a very good place.
@Flink up to you when we want to tag a 1.0. We should talk about what that workflow looks like (and document it) but otherwise I'm quite comfortable with these plugins. |
Add links to official dokku datastorage plugins
Something that has been a long time coming, but here are official dokku datastores.
Note that all have been marked as beta (because they are!) and their implementations may change wildly. All plugins appear to work fine under docker 1.7. I plan on formalizing a release process for each, as well as guiding their development.
All plugins use the official docker images, and I do not intend to change this. Their interface should stay the same, and in fact the diffs between each plugin should be quite minimal.
One thing I plan on noting in the documentation is that these datastores do not provide any sort of backup solution, and it is up to the developer to implement such a thing for their system (if their data is important enough).
All plugins roughly meet the spec proposed by @miraculixx in #854, with a few changes:
service:unexposecommand, to remove any exposed ports.service:aliascommand, which allows users to change the alias in use by a service.service:deletetoservice:destroy, to match how the core works//var/lib/dokku/services/DATASTORE/SERVICE_NAMEinstead of the home directory.docker-argspluginhook instead of thedokku:linkplugin, to reduce dependencies.Available datastore plugins
TODO:
expose/unexpose.Affexted existing datastore maintainers /cc @Kloadut @ohardy @hughfletcher @jlachowski @jeffutter @Flink @luxifer @sekjun9878 @robv @blag