@michaelshobbs what is the sed stuff here supposed to be doing?

Figured out the issue and now everything is consolidated!

That sed stuff reformats shell export statements to the docker env file format.

from https://docs.docker.com/reference/commandline/run/

The --env-file flag takes a filename as an argument and expects each line to be in the VAR=VAL format, mimicking the argument passed to --env. Comment lines need only be prefixed with #

Yeah, I figured it out and everything should be fine now :)

I get why from a code perspective we would want to do this. However, I'm uncomfortable with how often we are calling dokku from within dokku. The more we do this the longer traces get and the hard it is to troubleshoot issues. This is obviously one of the shortcomings with bash. Just my opinion though.

What if we had an export_config()function and --export called that? Then we could use that function internally as well?

The point of this is so that we can replace the config plugin with something else. If we just shove it into the common functions, that doesn't really help the matter.

Why not put the function in the config plugin and that was other plugins can implement it?

EDIT: My thinking is to optimize for core ease of use while giving the option of reimplementation to the plugin community. "Batteries included but replaceable" 😄

As in put it in a functions file and source that in other plugins when needed?

Yeah. I don't like the cross plugin sourcing bit, but again, we're doing this in bash....so....compromises?

I think this is good to merge, @michaelshobbs ?