Are you certain this is necessary? I have not run into this and have not heard of anyone having this issue either.

@michaelshobbs I'm afraid it is. This is what I got when I tried to deploy to the VM:

---> Attempt 1/5 Waiting for 5 seconds ...
       CHECKS expected result:
       http://localhost/_internal_/ok => ""
 !     /var/lib/dokku/plugins/enabled/checks/check-deploy: line 187: curl: command not found
 !     Check attempt 1/5 failed.
-----> Attempt 2/5 Waiting for 5 seconds ...
       CHECKS expected result:
       http://localhost/_internal_/ok => ""
 !     /var/lib/dokku/plugins/enabled/checks/check-deploy: line 187: curl: command not found
 !     Check attempt 2/5 failed.
-----> Attempt 3/5 Waiting for 5 seconds ...
       CHECKS expected result:
       http://localhost/_internal_/ok => ""
 !     /var/lib/dokku/plugins/enabled/checks/check-deploy: line 187: curl: command not found
 !     Check attempt 3/5 failed.
-----> Attempt 4/5 Waiting for 5 seconds ...
       CHECKS expected result:
       http://localhost/_internal_/ok => ""
 !     /var/lib/dokku/plugins/enabled/checks/check-deploy: line 187: curl: command not found
 !     Check attempt 4/5 failed.
-----> Attempt 5/5 Waiting for 5 seconds ...
       CHECKS expected result:
       http://localhost/_internal_/ok => ""
remote: Could not start due to 1 failed checks.
 !     /var/lib/dokku/plugins/enabled/checks/check-deploy: line 187: curl: command not found
 !     Check attempt 5/5 failed.

This can be easily reproduced by doing vagrant up and then vagrant ssh followed by any curl command. The result should be:

vagrant@dokku:~$ curl
The program 'curl' is currently not installed. You can install it by typing:
sudo apt-get install curl

I agree with you.. it's strange that no one noticed this... maybe I am doing something silly. But the steps I gave you are the exact ones I used.

This is on master?

Yes, this happened while on the master branch.

On 18 Nov 2015, at 18:17, Michael Hobbs notifications@github.com wrote:

This is on master?

—
Reply to this email directly or view it on GitHub.

I'm thinking your vagrant up failed or maybe you have a really old version of the base box? You might try a vagrant destroy & vagrant up again and post that output in a gist? I can confirm a fresh vagrant up in my env includes curl.

Oh crap. My bad. You are correct this is indeed a bug. I don't think this is the correct place to do this however. Perhaps here would make more sense: https://github.com/progrium/dokku/blob/master/Makefile#L80-L81

Not sure what changed to cause this though....maybe it was our move to bento? /cc @josegonzalez

#1665

Except that #1665 didn't actually remove curl from this PR's vagrant setup; just the deb version.

Also, the dokku deb package depends on curl. So in that version you end up with curl anyway.

Oh nevermind about #1665 I see it now in the top-level Makefile line 102 was removed. That should be added back.

@pmvieira let me know if you're cool updating this PR to revert that regression

@michaelshobbs Sure, not a problem, will do and update the PR

gracias!

That's that line added back @michaelshobbs :)

@pmvieira mind squashing?

That's the opposite of squashing 😄

Sorry @michaelshobbs ... 😊 Should know better not to commit while sleepy

No worries. Thanks for the PR.