这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix "Must specify DOMAIN" error over ssh #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix "Must specify DOMAIN" error over ssh #1691

wants to merge 1 commit into from

Conversation

@u2mejc
Copy link
Contributor

@u2mejc u2mejc commented Nov 14, 2015

Resolves #1614

u2mejc
u2mejc reviewed Nov 14, 2015
View reviewed changes
dokku
Copy link
Contributor Author

@u2mejc u2mejc Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This disables globbing which was causing the *.balh to disappear from the end.

@michaelshobbs
Copy link
Member

michaelshobbs commented Nov 14, 2015

the previous egrep command is a regex match that looks for the fixed string. ^ is beginning of the line and $ is end of line. So it translates to matching a fixed string. Maybe I'm missing the point here?

@michaelshobbs
Copy link
Member

michaelshobbs commented Nov 19, 2015

Oh I'm dumb. In the wildcard case, egrep will treat the string as a regexp.

@michaelshobbs
Copy link
Member

michaelshobbs commented Nov 19, 2015

However this does break adding domains that match substrings....
i.e.

root@dokku:~/dokku# dokku apps:create testapp
Creating testapp... done
root@dokku:~/dokku# dokku domains:add testapp www.test.dokku.me
-----> Creating new /home/dokku/testapp/VHOST...
-----> Setting config vars
       DOKKU_NGINX_PORT: 80
-----> Configuring testapp.dokku.me...
-----> Configuring www.test.dokku.me...
-----> Creating http nginx.conf
-----> Configuring testapp.dokku.me...
-----> Configuring www.test.dokku.me...
-----> Creating http nginx.conf
-----> Added www.test.dokku.me to testapp
root@dokku:~/dokku# dokku domains:add testapp test.dokku.me
test.dokku.me is already defined for testapp
root@dokku:~/dokku# dokku domains testapp
=====> testapp Domain Names
testapp.dokku.me
www.test.dokku.me

@michaelshobbs michaelshobbs mentioned this pull request Nov 19, 2015
Merged
@josegonzalez
Copy link
Member

josegonzalez commented Nov 19, 2015

Closing in favor of #1709. Thanks for the initial work @u2mejc!

michaelshobbs added a commit that referenced this pull request Nov 19, 2015
@michaelshobbs
Merge pull request #1709 from progrium/1614_mh-wildcard-domains
6a51ec0 
fix Must specify DOMAIN error over ssh (supercedes #1691)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@u2mejc @michaelshobbs @josegonzalez