Cause certs:remove to return non zero on error #1684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caught when writing the certs.bats. This patch will return non zero on error instead of zero which can casue false negatives in testing.
Member
|
Is it fair to assume you tested this change with #1683? |
Member
|
Can you rebase this and add a test? |
Contributor
Author
|
@josegonzalez The test already exists in #1683. The certs.bats is testing for non zero exit code, but currently |
josegonzalez
added a commit
that referenced
this pull request
Nov 12, 2015
Cause certs:remove to return non zero on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caught when writing the certs.bats. This patch will return
non zero on error instead of zero which can casue false negatives
in testing.