-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Replace curl with wget; see #1567 #1665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice! I'm in the middle of making a release, but this will go into 0.4.5 :) |
|
Heh. You're presuming it won't Break Everything. Waiting for 0.4.5 is a good idea :) |
docs/troubleshooting.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The english here was always solid :P
3515044 to
99ffbc0
Compare
|
So, one potential issue with this is that both Curl has # curl -sS is silent, but still prints errors
$ curl -sSL 'http://httpbin.org/status/200'
$ curl -sSL 'http://httpbin.org/status/404'
$ curl -sSL 'http://httpbin.org/status/500'
$ curl -sSL 'http://example.invalid'
curl: (6) Could not resolve host: example.invalid
# wget -q is completely silent
$ wget -qO- 'http://httpbin.org/status/200'
$ wget -qO- 'http://httpbin.org/status/404'
$ wget -qO- 'http://httpbin.org/status/500'
$ wget -qO- 'http://example.invalid'
# wget -nv is almost silent, but prints on every request
$ wget -nv -O- 'http://httpbin.org/status/200'
2015-11-06 08:17:57 URL:http://httpbin.org/status/200 [0/0] -> "-" [1]
$ wget -nv -O- 'http://httpbin.org/status/400'
http://httpbin.org/status/404:
2015-11-06 08:18:00 ERROR 404: NOT FOUND.
$ wget -nv -O- 'http://httpbin.org/status/500'
http://httpbin.org/status/500:
2015-11-06 08:18:05 ERROR 500: INTERNAL SERVER ERROR.
$ wget -nv -O- 'http://example.invalid'
wget: unable to resolve host address 'example.invalid'We can either:
|
|
And, if we need to be able to pass the output along, we can send stderr into a subshell, and stdout wherever $ wget -nv -O - 'http://example.invalid' 2> >(grep '^wget: ') > /dev/null
wget: unable to resolve host address 'example.invalid' |
|
Yeah, I need to revisit things, especially around what output goes where in the bats tests. |
|
Dropping this PR's scope. We could probably make wget to work everywhere, but curl is way more developer friendly for us, especially its |
638acf7 to
a49adef
Compare
Replace curl with wget; see #1567
Let's see if this passes CI...
(it should, but there are some subtleties in curl vs wget that I'm going to double-check while CI runs)