这是indexloc提供的服务，不要输入任何密码
Skip to content

Resolve SC2145: 'Argument mixes string and array.' #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2015
Merged

Resolve SC2145: 'Argument mixes string and array.' #1653

merged 1 commit into from
Nov 6, 2015

Conversation

@callahad
Copy link
Contributor

@callahad callahad commented Nov 4, 2015

@callahad
Copy link
Contributor Author

callahad commented Nov 4, 2015

Wait on merging this one -- need to double check the printf behavior

@callahad
Copy link
Contributor Author

callahad commented Nov 4, 2015

OK, commit 84c0988 looks good for this.

$ cat ./sc2145.sh
#!/usr/bin/env bash

a() {
  printf "%-25s %-25s %-25s %-25s\n" "-----> $@"
}

b() {
  printf "%-6s %-18s %-25s %-25s %-25s\n" "----->" "$@"
}

a "foo" "bar" "baz" "qux"
b "foo" "bar" "baz" "qux"

$ ./sc2145.sh
-----> foo                bar                       baz                       qux
-----> foo                bar                       baz                       qux

@callahad
Copy link
Contributor Author

callahad commented Nov 4, 2015

（╯°□°）╯︵ ┻━┻

remote: -----> Building test-config-1942 from herokuish...
remote: WARNING: Your kernel does not support memory swappiness capabilities, memory swappiness discarded.
To dokku@dokku.me:test-config-1942
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'dokku@dokku.me:test-config-1942'
+ failed git-push
+ echo '************ git-push failed ************'
************ git-push failed ************

@callahad
Copy link
Contributor Author

callahad commented Nov 4, 2015

（╯°□°）╯︵ ┻━┻

not ok 43 (core) port exposure (xip.io style hostnames)
...
# curl: (6) Could not resolve host: my-cool-guy-test-app.127.0.0.1.xip.io

Between both CI runs for this PR, 1547 and 1550, everything has actually passed.

Should we just merge it?

@josegonzalez
Copy link
Member

josegonzalez commented Nov 4, 2015

My personal policy is to merge failing PRs only when there is a doc change. All others require a re-run.

@callahad
Copy link
Contributor Author

callahad commented Nov 4, 2015

Works for me :)

josegonzalez added a commit that referenced this pull request Nov 6, 2015
@josegonzalez
Merge pull request #1653 from callahad/SC2145
a1983e0 
Resolve SC2145: 'Argument mixes string and array.'
@josegonzalez josegonzalez merged commit a1983e0 into dokku:master Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@callahad @josegonzalez