这是indexloc提供的服务，不要输入任何密码
Skip to content

Resolve SC2115: 'Use "${var:?}" to ensure this never expands to /' #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2015
Merged

Resolve SC2115: 'Use "${var:?}" to ensure this never expands to /' #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/apps/post-delete
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ set -eo pipefail; [[ $DOKKU_TRACE ]] && set -x
source "$PLUGIN_CORE_AVAILABLE_PATH/common/functions"

APP="$1"; IMAGE_REPO=$(get_app_image_repo $APP)
[[ -n $APP ]] && rm -rf "$DOKKU_ROOT/$APP" > /dev/null
[[ -n $APP ]] && rm -rf "${DOKKU_ROOT:?}/$APP" > /dev/null
Copy link
Contributor Author

@callahad callahad Nov 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prints a nice failure message and then exits if $DOKKU_ROOT is empty or unset:

$ cat sc2115.sh
#!/usr/bin/env bash
FOO=""
echo ${FOO:?}

$ ./sc2115.sh
./sc2115.sh: line 3: FOO: parameter null or not set

$ echo $?
1


# remove all application containers & images
# shellcheck disable=SC2046
Expand Down