这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@elhu
Copy link
Contributor

@elhu elhu commented Jan 13, 2022

Fixes #4990

@josegonzalez
Copy link
Member

Any chance you can add a test for this?

@elhu
Copy link
Contributor Author

elhu commented Jan 13, 2022

For sure! Any pointers on where to look?

@josegonzalez
Copy link
Member

I would create a test that runs the command and checks for zero exit code.

@josegonzalez
Copy link
Member

There should be a buildpack.bats you can checkout and add the test to.

@elhu
Copy link
Contributor Author

elhu commented Jan 13, 2022

Got it, I'll see if I can add that today or tomorrow.

@elhu
Copy link
Contributor Author

elhu commented Jan 14, 2022

Alright, I have a test, let's see if that works!

@josegonzalez josegonzalez merged commit 64d6c28 into dokku:master Jan 15, 2022
@elhu elhu deleted the 4990-set-stack-global-cache branch January 15, 2022 15:06
github-actions bot pushed a commit that referenced this pull request Jan 18, 2022
# History

## 0.26.7

Install/update via the bootstrap script:

```shell
wget https://raw.githubusercontent.com/dokku/dokku/v0.26.7/bootstrap.sh
sudo DOKKU_TAG=v0.26.7 bash bootstrap.sh
```

### Bug Fixes

- #5003: @josegonzalez Respect pre-existing .env files when preparing the herokuish buildenv
- #4950: @emdienn Use exported environment vars during pack build
- #4999: @elhu Purge cache for all apps when calling buildpacks:set-property with --global flag
- #4988: @fomojola Conditionally restart NGINX
- #4922: @josegonzalez Gitignore more built plugin triggers in apps plugin

### New Features

- #4964: @josegonzalez Add log message when running state is false
- #4970: @josegonzalez Log the string error and not bytes when there is an issue updating the cron schedule
- #4924: @josegonzalez Update devcontainer to include aliased go packages
- #4920: @josegonzalez Ensure related go source and vscode plugins are installed in devcontainer

### Documentation

- #4949: @IlyaSemenov docs: update herokuish upgrade instructions
- #4992: @anthonyshew Typo for deploying using image SHA
- #4976: @josegonzalez Update link in header to dokku pro
- #4972: @Dam-Buty Clarify cron:report command
- #4943: @Stormheg Fix typo in registry management documentation
- #4935: @josegonzalez Reword note about env vars in nginx config templates

### Other

- #4995: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 203 to 205 in /tests/apps/php
- #4978: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 201 to 203 in /tests/apps/php
- #4936: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 200 to 201 in /tests/apps/php
- #4937: @dependabot[bot] chore(deps): bump socket.io from 4.3.2 to 4.4.0 in /tests/apps/.websocket.disabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug clearing cache after setting the stack globally

2 participants