Add ability to filter returnable apps #4921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39eebaf to
d09c237
Compare
This helps centralize app-related listing fetching.
This increases the time to list apps from .05s to .2s~.3s on the simplest check, but the increased time is worth it for actually verifyng access to an app (should that need arise). We'll also want to add the same to app existence checks.
ce6e313 to
5eced46
Compare
Without this, we'd need to duplicate some logic or make it more complex via a plugin trigger.
Ideally we could use this to mock out different plugin paths with test implementations of user-auth-app, but for now setting something that won't generally fail is good enough.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
# History ## 0.27.0 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.27.0/bootstrap.sh sudo DOKKU_TAG=v0.27.0 bash bootstrap.sh ``` See the [0.27.0 migration guide](/docs/appendices/0.27.0-migration-guide.md) for more information on migrating to 0.27.0. ### Bug Fixes - #5063: @josegonzalez Fix buildx support for releases - #5061: @josegonzalez Use correct token when publish unit test results - #5057: @josegonzalez Ensure we use the correct variable for WAIT - #5052: @josegonzalez Run crontab under sudo to support rhel systems - #5051: @josegonzalez Ensure vector component sources have valid names - #5035: @nerg4l Fix help flag for logs command - #5019: @josegonzalez Only rename app domains associated with a global domain ### New Features - #5064: @josegonzalez Upgrade docker image to ubuntu focal - #5058: @josegonzalez Add .shellcheckrc - #5055: @josegonzalez Release dokku for 32-bit Raspbian Bullseye - #5050: @josegonzalez Set the default memory unit type to megabytes - #5017: @josegonzalez Add command to clear all proxy configs ### Refactors - #4921: @josegonzalez Add ability to filter returnable apps ### Documentation - #5056: @miku86 Fix typo in port management docs - #5018: @josegonzalez Add warning for setting PORT environment variable ### Other - #5062: @dependabot[bot] chore(deps): bump django from 3.1.13 to 3.1.14 in /tests/apps/dockerfile-release - #5053: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 211 to 212 in /tests/apps/php - #5038: @dependabot[bot] chore(deps): bump flask from 2.0.2 to 2.0.3 in /tests/apps/multi - #5048: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 210 to 211 in /tests/apps/php - #5039: @dependabot[bot] chore(deps): bump sinatra from 2.1.0 to 2.2.0 in /tests/apps/ruby - #5037: @dependabot[bot] chore(deps): bump flask from 2.0.2 to 2.0.3 in /tests/apps/python-flask - #5036: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 207 to 210 in /tests/apps/php - #5025: @dependabot[bot] chore(deps): bump jetty-servlet from 11.0.7 to 11.0.8 in /tests/apps/java - #5026: @dependabot[bot] chore(deps): bump werkzeug from 2.0.2 to 2.0.3 in /tests/apps/python-flask - #5027: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 206 to 207 in /tests/apps/php - #5021: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 205 to 206 in /tests/apps/php - #4975: @tcurdt add arm64 to the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, we are centralizing how apps are fetched - into either a plugin trigger or a call to
apps.DokkuApps()- which should allow us to properly filter apps in a single location, the apps plugin.