Filter --link and --volume flags during Dockerfile builds #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61f9500 to
13781a0
Compare
The link flag was previously not filtered _after_ fetching build args for dockerfile builds, which meant if a plugin exposed that in it's own docker-args-build trigger, it would break deploys. Additionally, allow for whitespaces between link and volume flags.
13781a0 to
52d9cb6
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Oct 6, 2021
# History ## 0.25.6 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.25.6/bootstrap.sh sudo DOKKU_TAG=v0.25.6 bash bootstrap.sh ``` ### Bug Fixes - #4841: @josegonzalez Ensure pack is run as root user when building apps in docker - #4836: @josegonzalez Fix custom dockerfile path detection - #4839: @josegonzalez Choose the correct app when a named remote is specified in the remote ssh client ### New Features - #4829: @josegonzalez Add ability to schedule process types in parallel - #4837: @josegonzalez Filter --link and --volume flags during Dockerfile builds ### Documentation - #4840: @josegonzalez Explain sha256 image digest alternative when reusing docker image tags for git:from-image deployments ### Tests - #4842: @josegonzalez Set default process list in test cnb buildpacks ### Other - #4832: @dependabot[bot] chore(deps): bump flask from 2.0.1 to 2.0.2 in /tests/apps/python-flask - #4833: @dependabot[bot] chore(deps): bump jinja2 from 3.0.1 to 3.0.2 in /tests/apps/python-flask - #4831: @dependabot[bot] chore(deps): bump flask from 2.0.1 to 2.0.2 in /tests/apps/multi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.