Changes for #482 to support setting/getting config props with spaces in the value #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
There was a problem hiding this comment.
Read on lines rather then words
|
i was just fighting with the same problem. can't wait for you patchset to be merged. I're a much better bash expert then I. |
There was a problem hiding this comment.
there is still a bug somewhere
running dokku config:set APP 'KEY="val val2"' works when runnings this commands directly
but when i do the same over ssh
ssh dokku@host:APP config:set 'KEY="val val2"'
the $# is 3 in one case and 4 over ssh :(
i am guessing the bug is in calling this command from 'sshcommand'
Member
|
Closed by #702 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some changes which improve how the config/commands plugin iterates over the environment variable hash to make setting config variables containing spaces possible, for example after this change this works: