Output logs when container rename fails and continue on #4767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to track a Dokku container vs an intermediate container or something created external to Dokku. The container is properly renamed later on, so the `upcoming` part is just an indicator that the container has potentially not yet passed healthchecks.
This allows folks to later investigate why the rename failed (probably an app bug) and helpfully posts the container logs. If multiple containers fail, they may have a ton of output, but this is better than not knowing what is going on. Closes #3900
This fixes issues where a previous deploy may have failed, consuming that other slot.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 6, 2021
# History ## 0.25.3 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.25.3/bootstrap.sh sudo DOKKU_TAG=v0.25.3 bash bootstrap.sh ``` ### Bug Fixes - #4767: @josegonzalez Output logs when container rename fails and continue on - #4764: @josegonzalez Reference correct plugin when setting up app-json plugin ### Refactors - #4741: @josegonzalez Use a Dockerfile to speed up env var injection for herokuish app builds ### Documentation - #4763: @josegonzalez Remove install doc references to removed web installer ### Other - #4766: @josegonzalez Capitalize certain log messages for aesthetic reasons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows folks to later investigate why the rename failed (probably an app bug) and helpfully posts the container logs.
If multiple containers fail, they may have a ton of output, but this is better than not knowing what is going on.
Also set initial container name for docker-local deploys.
Closes #3900