Change exit code when app does not exist #4374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Feb 3, 2021
stickler-ci
reviewed
Feb 3, 2021
0878a23 to
f6fb377
Compare
… set at the top-level LogFail shouldn't be called internally if at all possible.
…g commands when the app is missing
f6fb377 to
548ca90
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2021
# History ## 0.24.0 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.24.0/bootstrap.sh sudo DOKKU_TAG=v0.24.0 bash bootstrap.sh ``` See the [0.24.0 migration guide](/docs/appendices/0.24.0-migration-guide.md) for more information on migrating to 0.24.0. ### Bug Fixes - #4449: @josegonzalez Gitignore trigger symlink - #4447: @josegonzalez Checkout code to ensure the bump-azure script is available ### New Features - #4453: @josegonzalez Simplify tar and zip deploys via git:from-archive - #4450: @josegonzalez Simplify docker image deploys via git:from-image - #4379: @josegonzalez Allow builders to be detected based on repository contents - #4425: @josegonzalez Implement heroku's postdeploy deployment task - #4424: @josegonzalez Implement git:auth command - #4419: @josegonzalez Add parallelism to certain proxy commands ### Refactors - #4374: @josegonzalez Change exit code when app does not exist ### Documentation - #4451: @josegonzalez Update links to builder documentation to avoid extra rewrite - #4448: @josegonzalez Add documentation for git push to dokku-in-docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow wrappers around dokku to avoid needing two calls to dokku - one for apps:exists, the other for the command you want to run itself - to see if the app does not exist or if the error was something else.