Making the search field's search thread safe and interruptible #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the search was not thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've pulled this out of my too big pull request from a few months ago. I've tried to keep all of my extra functionality out of this branch for now.
The search has a delay on it which made searches less responsive. I tracked this back to concurrency issues with the search. So I've made the search thread safe and clearly interruptible.
This may look like a lot of changes but most everywhere that interacted with starting a search just needed to be modified a little bit.
With this change functionality should be essentially the same, but more responsive/lower latency. Because it should be safe, and only snappier, I've gone ahead and set the delay to 0ms.