making search results at the top optional and preferring the user's sorting method #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting algo where possible
dlemmermann
approved these changes
Oct 29, 2025
Collaborator
|
Merged it, but please also try to add the new feature to the demo apps. I have done this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue where the sorting order was important to the user and as soon as they started typing to search it was wrong. I tracked that down to the inner comparator where default alphanumeric is used when both terms match the search. Instead I've set both terms to use the custom comparator when both are valid results, maintaining order.
I've also added a property for whether search results are shown at the top of the list, useful when users do not want items shown out of order. Default value maintains previous functionality.