Enhance TextView Context Menu, Fix StyleableProperty Beans, and Refactor TextViewSkin #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(TextViewSkin): Simplify SelectableText internal logic TextView: - Conditionally show "Copy Selection" context menu item based on text selection. - Corrected `getBean()` in `highlightFill`, `highlightStroke`, and `highlightTextFill` StyleableObjectProperties to return `TextView.this`. - Improved Javadoc for highlight properties. - Aligned CSS default for `-fx-highlight-fill` with the JavaFX property default (Color.BLUE). TextViewSkin: - Inlined child node setup in `SelectableText` constructor. - Removed unused `setText(Text)` method in `SelectableText`. - Removed redundant `layoutChildren()` override in `SelectableText`.
|
dlemmermann
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(TextView): Enhance context menu and correct StyleableProperty bean;
refactor(TextViewSkin): Simplify SelectableText internal logic
TextView:
getBean()inhighlightFill,highlightStroke, andhighlightTextFillStyleableObjectProperties to returnTextView.this.-fx-highlight-fillwith the JavaFX property default (Color.BLUE).TextViewSkin:
SelectableTextconstructor.setText(Text)method inSelectableText.layoutChildren()override inSelectableText.