这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: handle c.wasReplaced() event for single selection in SelectionBox. #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

fix: handle c.wasReplaced() event for single selection in SelectionBox. #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 35 additions & 24 deletions gemsfx/src/main/java/com/dlsc/gemsfx/SimpleFilterView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,31 +306,13 @@ public List<T> fromString(String string) {

ListChangeListener<? super T> l = c -> {
while (c.next()) {
if (c.wasAdded()) {
c.getAddedSubList().forEach(item -> {
ChipView<T> chip = new ChipView<>();
chip.setValue(item);
chip.textProperty().bind(Bindings.createStringBinding(() -> {
StringConverter<T> itemConverter = box.getItemConverter();
if (itemConverter != null) {
return itemConverter.toString(item);
}
return "";
}, box.itemConverterProperty()));
chip.setOnClose(status -> box.getSelectionModel().clearSelection(box.getItems().indexOf(status)));
getChips().add(chip);
map.computeIfAbsent(box, it -> new HashMap<>()).put(item, chip);
});
if (c.wasReplaced()) {
removeChips(c.getRemoved(), box);
addChips(c.getAddedSubList(), box);
} else if (c.wasRemoved()) {
c.getRemoved().forEach(item -> {
Map<Object, ChipView<?>> innerMap = map.get(box);
if (innerMap != null) {
ChipView<?> chip = innerMap.remove(item);
if (chip != null) {
getChips().remove(chip);
}
}
});
removeChips(c.getRemoved(), box);
} else if (c.wasAdded()) {
addChips(c.getAddedSubList(), box);
}
}
};
Expand All @@ -341,6 +323,35 @@ public List<T> fromString(String string) {
return box;
}

private <T> void removeChips(List<? extends T> removedList, SelectionBox<T> box) {
removedList.forEach(item -> {
Map<Object, ChipView<?>> innerMap = map.get(box);
if (innerMap != null) {
ChipView<?> chip = innerMap.remove(item);
if (chip != null) {
getChips().remove(chip);
}
}
});
}

private <T> void addChips(List<? extends T> addedList, SelectionBox<T> box) {
addedList.forEach(item -> {
ChipView<T> chip = new ChipView<>();
chip.setValue(item);
chip.textProperty().bind(Bindings.createStringBinding(() -> {
StringConverter<T> itemConverter = box.getItemConverter();
if (itemConverter != null) {
return itemConverter.toString(item);
}
return "";
}, box.itemConverterProperty()));
chip.setOnClose(status -> box.getSelectionModel().clearSelection(box.getItems().indexOf(status)));
getChips().add(chip);
map.computeIfAbsent(box, it -> new HashMap<>()).put(item, chip);
});
}

/**
* Creates a new instance of a {@code SelectionBox}. This method serves as a factory for creating
* selection boxes, in case customization or modification of the default selection box behavior
Expand Down
Loading