Ensure proper width calculation in SelectionBoxSkin popup. #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the `SelectionBoxSkin` popup to compute its preferred width dynamically based on content and bounds, improving layout flexibility. Added a listener to adjust the viewport width of the scroll pane dynamically based on the options box width. These changes enhance visual consistency and adaptability.
Adjusted padding values in several CSS selectors to ensure uniform spacing and alignment across elements. Removed an unused style block to clean up the code. These changes improve overall UI consistency and maintainability.
Refactored the `scrollPane` to be a class-level field instead of a local variable, enhancing code clarity and reusability. Also added a default preferred viewport width in the `updatePopupContent` method to ensure consistent scroll behavior. These changes improve maintainability and UI flexibility.
|
dlemmermann
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the
SelectionBoxSkinpopup to compute its preferred width dynamically based on content and bounds, improving layout flexibility. Added a listener to adjust the viewport width of the scroll pane dynamically based on the options box width. These changes enhance visual consistency and adaptability.