Fix SimpleStringConverter to properly apply nullDefaultValue #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed an issue where nullDefaultValue was not applied due to an override in toString(). - Now, toString() always delegates to the valueToStringCallback, allowing proper null handling. - Updated the default constructor to safely handle null values. Updated SimpleStringConverter with a clearer default null handling and refined its callback logic. Enhanced the demo by adding a status ComboBox, demonstrating enum handling and the use of converters for better formatting.
|
dlemmermann
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Previously,
SimpleStringConverterhad an issue wherenullDefaultValuewas not applied correctly.This happened because the
toString(T object)method explicitly returned""when the object wasnull,bypassing the intended handling in the constructor.
Fix
toString(T object)always callsvalueToStringCallback.call(object), ensuring the logic setin the constructor (including
nullDefaultValue) is properly applied.Impact
nullDefaultValueshould now work as expected.nullDefaultValue.