feat(selection-box): wrap options in ScrollPane and add directional extra nodes #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
leewyatt
commented
Jan 31, 2025
- Use a ScrollPane to prevent the popup from growing too large with many options
- Replace extraButtons with a more flexible approach: extra nodes on top, bottom, left, and right
…xtra nodes - Use a ScrollPane to prevent the popup from growing too large with many options - Replace extraButtons with a more flexible approach: extra nodes on top, bottom, left, and right
The DEFAULT_SHOW_EXTRA_BUTTON constant was declared but never used in the code. Its removal cleans up unnecessary code, improving maintainability and readability.
|
dlemmermann
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.