Fix cursor misalignment in SearchField when left node is present #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a left-side node is added to the SearchField component, clicking inside the text field does not position the cursor correctly. This commit overrides the getIndex method in SearchFieldEditorSkin to adjust the x-coordinate by subtracting the width of the left node before invoking the superclass method. This correction ensures that the cursor accurately reflects the user's click position within the text field, even when a left node is present.
|
dlemmermann
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: When a left-side node is added to the SearchField component, clicking inside the text field does not position the cursor correctly.