Fix issues with popup visibility in SelectionBox: handling early show/hide calls and property cleanup #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the SHOW_POPUP_PROPERTY to manage the visibility of the popup during initialization and property changes. Added a button in the demo application to trigger the popup display, enhancing the control's interactivity.
|
dlemmermann
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues in the SelectionBox component related to the popup visibility control:
Fixed the issue where calling show() or hide() before the skin initialization would not properly display the popup. Now the popup behavior works as expected, even when these methods are invoked prior to skin setup.
Resolved the problem where the code previously forgot to remove the communication key in the properties after calling show() or hide(). This key is now properly cleaned up post-action to prevent unwanted behavior.