这是indexloc提供的服务，不要输入任何密码
Skip to content

feature: scope api keys to orgs #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2024
Merged

feature: scope api keys to orgs #2833

merged 2 commits into from
Nov 25, 2024

Conversation

@densumesh
Copy link
Contributor

@densumesh densumesh commented Nov 22, 2024

Please indicate what issue this PR is related to and @ any maintainers who are relevant

@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from 510d150 to b5d92aa Compare November 22, 2024 02:38
@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from b5d92aa to ca9d188 Compare November 22, 2024 02:39
@densumesh densumesh linked an issue Nov 22, 2024 that may be closed by this pull request
refactor: tie API keys to orgs instead of users #2813
Closed
@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from ca9d188 to 76159d8 Compare November 22, 2024 02:44
@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from 76159d8 to 418d337 Compare November 22, 2024 02:48
@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from 418d337 to 13faf12 Compare November 24, 2024 23:52
@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from 13faf12 to ff78ad8 Compare November 24, 2024 23:54
@skeptrunedev skeptrunedev force-pushed the ds/scope-api-keys-to-orgs branch from ff78ad8 to 80eb5c1 Compare November 25, 2024 00:10
@skeptrunedev
Copy link
Contributor

skeptrunedev commented Nov 25, 2024

image
image

Role's aren't getting set correctly when I get the key back after creation

skeptrunedev
skeptrunedev requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment •
edited by densumesh
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • roles aren't getting set correctly on response after API key creation

@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from 80eb5c1 to eacea5c Compare November 25, 2024 02:02
@densumesh densumesh force-pushed the ds/scope-api-keys-to-orgs branch from eacea5c to dc35412 Compare November 25, 2024 02:03
@skeptrunedev skeptrunedev merged commit 79d5616 into main Nov 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skeptrunedev skeptrunedev skeptrunedev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor: tie API keys to orgs instead of users

3 participants

@densumesh @skeptrunedev