feature: chunkr integration for pdf2md #2807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc45c7f to
6f18db9
Compare
skeptrunedev
requested changes
Nov 20, 2024
Contributor
skeptrunedev
left a comment
There was a problem hiding this comment.
Got the commits cleaned up w/ the merge removed and overall collapsed down to 1 with a feature: prefix.
One major change off the bat in terms of UI flow:
Backend then has an issue when polling for task status:
Contributor
Author
|
Should I just remove the provider logic completely then? Or just change the frontend? |
Contributor
Just change the frontend. Also seems like we should re-label the input as |
skeptrunedev
requested changes
Nov 20, 2024
46a339c to
13f5504
Compare
13f5504 to
1c28a0c
Compare
skeptrunedev
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please indicate what issue this PR is related to and @ any maintainers who are relevant
This PR implements Chunkr support for pdf2md.
@skeptrunedev