Fix term-cursor--immediate with optional arguments
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default `term-cursor--immediate` is called as part of the `lsp-ui-doc-frame-hook`, which is run with two arguments, and will therefore throw an error each time time, see syl20bnr/spacemacs#15667.
fnussbaum
added a commit
to fnussbaum/spacemacs
that referenced
this pull request
Sep 17, 2024
Remove `lsp-ui-doc-frame-hook` from `term-cursor-triggers` to fix syl20bnr#15667. The hook is run with two arguments, but the handler function `term-cursor--immediate` does not expect any. (It can be added back in case denrat/term-cursor.el#5 is merged and if it is still deemed necessary.) Also do not enable `global-term-cursor-mode` in daemon mode unless a terminal frame is created.
fnussbaum
added a commit
to fnussbaum/spacemacs
that referenced
this pull request
Sep 17, 2024
Remove `lsp-ui-doc-frame-hook` from `term-cursor-triggers` to fix syl20bnr#15667. The hook is run with two arguments, but the handler function `term-cursor--immediate` does not expect any. (It can be added back in case denrat/term-cursor.el#5 is merged and if it is still deemed necessary.) Also do not enable `global-term-cursor-mode` in daemon mode unless a terminal frame is created.
fnussbaum
added a commit
to fnussbaum/spacemacs
that referenced
this pull request
Sep 17, 2024
Remove `lsp-ui-doc-frame-hook` from `term-cursor-triggers` to fix syl20bnr#15667. The hook is run with two arguments, but the handler function `term-cursor--immediate` does not expect any. (It can be added back in case denrat/term-cursor.el#5 is merged and if it is still deemed necessary.) Also do not enable `global-term-cursor-mode` in daemon mode unless a terminal frame is created.
smile13241324
pushed a commit
to syl20bnr/spacemacs
that referenced
this pull request
Sep 17, 2024
Remove `lsp-ui-doc-frame-hook` from `term-cursor-triggers` to fix #15667. The hook is run with two arguments, but the handler function `term-cursor--immediate` does not expect any. (It can be added back in case denrat/term-cursor.el#5 is merged and if it is still deemed necessary.) Also do not enable `global-term-cursor-mode` in daemon mode unless a terminal frame is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
term-cursor--immediateis called as part of thelsp-ui-doc-frame-hook, which is run with two arguments, and will therefore throw an error each time time, see syl20bnr/spacemacs#15667.(I do not know why or if it still needs to be part of this hook, but I think it is the right thing to do in any case to support arbitrary hooks run with arguments).