This repository was archived by the owner on Jul 23, 2021. It is now read-only.
fix: solve problem with potentially existing method responses and new ones #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dperjar, @cdichiara, I think I fixed the problem causing your bug described in #17. Can you please pull this version here and try it out? When everything works again I will merge this with master and push this to the npm repo. |
This was referenced Feb 10, 2017
Contributor
Contributor
Author
|
@dperjar Thanks for testing this! I will update the version and push this to the npm repo |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 157 156 -1
Branches 20 20
=====================================
- Hits 157 156 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was, that the change in 0.5.6 didn't account an already existing ResponseMethods array with completely different entries.
Now mixed existing and new ones are possible.
Like response 200 and 400 are existing, and in the documentation part 200 and 404 are described, but not 400.
Also potentially empty existing MethodeResponses array should be no problem
fixes #17