3x-5x faster hash in nacl-fast. #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of u64 by inlining everything and doing separate calculations on separate buffers of high and low bits of 64-bit numbers. Before: Benchmarking crypto_hash (1024 bytes) 1.550 MB/s 1587.302 ops/s Benchmarking crypto_hash (16 KiB) 2.248 MB/s 143.885 ops/s After: Benchmarking crypto_hash (1024 bytes) 3.756 MB/s 3846.154 ops/s Benchmarking crypto_hash (16 KiB) 11.004 MB/s 704.225 ops/s
|
!!! |
Owner
Author
|
@KAepora :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of u64 by inlining everything and doing separate calculations on
separate buffers of high and low bits of 64-bit numbers.
Before:
Benchmarking crypto_hash (1024 bytes)
1.550 MB/s
1587.302 ops/s
Benchmarking crypto_hash (16 KiB)
2.248 MB/s
143.885 ops/s
After:
Benchmarking crypto_hash (1024 bytes)
3.756 MB/s
3846.154 ops/s
Benchmarking crypto_hash (16 KiB)
11.004 MB/s
704.225 ops/s