README: add note about performance in Jest tests #221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hah! Thanks, but since this pretty specific to a particular library, I think it belongs in the wiki rather than README. Could you please add it there? (I think it should be open for editing but if not, please let me know). |
Contributor
|
I agree, this is pretty specific and should be put in the wiki. I'll go ahead and create a section there. |
Contributor
|
I added this note to the wiki under the Performance in Jest page. @Valodim if this page looks good, I think this issue can be closed @dchest |
Author
|
lgtm. thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tweetnacl-js is noticeably slow in Jest tests, which can be fixed by simply configuring the test vm to include the
Mathobject. Took us a while to figure out, maybe this will save someone else the trip :)