这是indexloc提供的服务，不要输入任何密码
Skip to content

Typings: secretbox.open can return false #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2016
Merged

Typings: secretbox.open can return false #113

merged 1 commit into from
Dec 13, 2016
+2 −2

Conversation

@dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Dec 13, 2016

Here:

nacl.secretbox.open = function(box, nonce, key) {
  // ...
  if (c.length < 32) return false;
  if (crypto_secretbox_open(m, c, c.length, nonce, key) !== 0) return false;
  // ...
};

And here:

nacl.box.open = function(msg, nonce, publicKey, secretKey) {
  // ...
  return nacl.secretbox.open(msg, nonce, k);
};

Not sure if box.after is also affected.

@dchest dchest merged commit 46a0de6 into dchest:master Dec 13, 2016
@dchest
Copy link
Owner

dchest commented Dec 13, 2016

Thanks, not sure how I missed it! I need to write tests for this.

@dbrgn dbrgn deleted the fix-types branch December 13, 2016 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dbrgn @dchest