Refine typehints in special/llm.py
#1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
special/llm.py
e3b59bc to
eb8b3b0
Compare
* "Optional" can be replaced by "| None" in modern Pythons * "Tuple" can be replaced by lowercase "tuple" in modern Pythons * variable "cur" has a type of pymysql.cursors.Cursor * typehint contextlib variable "redirect" * change exit code to "int(e.code or 0)", a semantic change * split build_command_tree() using an inner _build_command_tree() to simplify the return type * don't pass mutable COMMAND_TREE as an argument default * typehint almost all function arguments * typehint all return types * remove a needless "return" statement * reformat many parameter lists as vertical
eb8b3b0 to
e687b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optionalcan be replaced by| Nonein modern PythonsTuplecan be replaced by lowercasetuplein modern Pythonscurhas a type ofpymysql.cursors.Cursorredirectint(e.code or 0), a semantic changebuild_command_tree()using an inner_build_command_tree()to simplify the return typeCOMMAND_TREEas an argument defaultreturnstatementChecklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff format && uv run mypy --install-types .to lint and format the code.