Switch from pyaes to pycryptodomex #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Contributor
|
pycryptodomex does look to be more actively maintained. |
Contributor
Author
|
For sure, I found that pyaes (almost) got retired in 2023: https://pagure.io/releng/issue/11685 So I think that's the reason why it was switched to pycryptodomex |
Contributor
|
Let's merge this. Can you add it to the changelog? |
fd813bf to
229b3c0
Compare
Contributor
Author
|
Great! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from pyaes to pycryptodomex
I got this patch from the Fedora package maintainer terjeros:
https://src.fedoraproject.org/rpms/mycli/blob/rawhide/f/0002-Switch-from-pyaes-to-pycryptodomex.patch
Not sure if this is a good idea, please leave your comments in the PR
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff formatto lint and format the code.