fix: ssl check wrong #1356
Merged
fix: ssl check wrong #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when sqlexecutre check if user use ssl, it just check the ssl variable is not None, but if user use ssl actually, the ssl map will have a key 'enable' and value will be True this will fix when using plain connection mode(without ssl), even use correct password, mycli still return error Bad Handshake
Contributor
|
Hi! Thanks! Can you resolve the (trivial) doc conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when sqlexecutre check if user use ssl, it just check the ssl variable is not None, but if user use ssl actually, the ssl map will have a key 'enable' and value will be True
this will fix when using plain connection mode(without ssl), even use correct password, mycli still return error Bad Handshake
we can confirm it by using wireshark to capture the login request package, with this fix, the
Switch to SSL after handshakewill benot setChecklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff formatto lint and format the code.