这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rolandwalker
Copy link
Contributor

@rolandwalker rolandwalker commented Sep 27, 2025

Description

Test on Python 3.14, which is soon to be released. already released at the time of merging.

  • add Python 3.14 to the test matrix
  • update sqlglot in the hope that sqlglotrs 27 releases for Python 3.14
  • refine some dedented strings, since apparently dedent() changed subtly in the standard library
  • questionable: cover up a bug in tests for watch_query, which is apparently running too quickly under 3.14. Rationalization: it is a flaky test at best.

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).
  • I ran uv run ruff check && uv run ruff format to lint and format the code.

@rolandwalker rolandwalker self-assigned this Sep 27, 2025
@rolandwalker rolandwalker force-pushed the RW/ci-test-on-3-14 branch 6 times, most recently from ef4d3fa to c6d159f Compare September 27, 2025 22:40
@rolandwalker
Copy link
Contributor Author

This is currently blocked by a transitive dependency of the latest llm library. llm will presumably catch up when Python 3.14 is released.

@rolandwalker rolandwalker force-pushed the RW/ci-test-on-3-14 branch 3 times, most recently from 78a3219 to 7688e3b Compare October 7, 2025 17:09
@rolandwalker
Copy link
Contributor Author

I'm not sure the above diagnosis was exactly correct, but the dependencies do build now. However, there are some legitimate test failures. The visible one here currently is a failure in watch_query, which runs too fast:

But even if we skip that test, other behave tests fail:

Errored scenarios:
  test/features/auto_vertical.feature:4  auto_vertical on with small query
  test/features/basic_commands.feature:15  check our application_name
  test/features/basic_commands.feature:19  insert the date
  test/features/crud_table.feature:4  create, insert, select from, update, drop table
  test/features/crud_table.feature:24  select null values
  test/features/iocommands.feature:10  tee output from query

This is a surprising number of problems. I can duplicate some of them locally. Some of them seem at first glance that they might be related to our pinning of click.

@rolandwalker
Copy link
Contributor Author

Some of the behave tests appear to be failing due to changes in the stdlib around dedenting or similar. This says that the tests are fragile, not that Python 3.14 is buggy in some way. Still, we have to go through the tests one-by-one.

@rolandwalker rolandwalker force-pushed the RW/ci-test-on-3-14 branch 5 times, most recently from 6484307 to a972ca6 Compare October 8, 2025 20:18
 * add Python 3.14 to the test matrix
 * update sqlglot in the hope that sqlglotrs 27 releases for Python 3.14
 * refine some dedented strings, since apparently dedent() changed
   subtly in the standard library
 * questionable: cover up a bug in tests for watch_query, which is
   apparently running too quickly under 3.14.  Rationalization: it is
   a flaky test at best.
@rolandwalker rolandwalker merged commit 8bbc7c7 into main Oct 8, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants