Typehinting pass on main.py and others #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove "type: ignore" comments where no longer needed after hinting * typehint output_res() * check that self.prompt_app is not None before finding width from it * remove needless return statement * typehint cli(), except for arguments * help mypy understand operations on SSL DSN parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
type: ignorecomments where no longer needed after hintingoutput_res()self.prompt_appis notNonebefore finding width from itreturnstatementcli(), except for argumentsChecklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff formatto lint and format the code.