Better handle empty-string passwords #1315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
Nones to detect when unset, because the empty string is a valid password. In particularwould have used
password_from_fileifpasswdwas the (falsey) empty string.It probably worked as expected because
password_from_filewas also returning the empty string when not available, but that is an awkward place to put the true default.I'm not yet smart enough to write a meaningful test for the CLI behavior, but did exercise this locally.
Checklist
changelog.md.AUTHORSfile (or it's already there).uv run ruff check && uv run ruff formatto lint and format the code.