这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rolandwalker
Copy link
Contributor

Description

aka --ssl-verify-server-cert. Since eg "false" is a truthy string, when we later do

# prune lone check_hostname=False
if not any(v for v in ssl_config.values()):
    ssl_config_or_none = None

the pruning might not happen according to what the comment describes.

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).
  • I ran uv run ruff check && uv run ruff format to lint and format the code.

aka --ssl-verify-server-cert.  Since eg "false" is a truthy string, when
we later do

    # prune lone check_hostname=False
    if not any(v for v in ssl_config.values()):
        ssl_config_or_none = None

the pruning might not happen according to what the comment describes.
@rolandwalker rolandwalker self-assigned this Aug 16, 2025
@rolandwalker rolandwalker merged commit c03026f into main Aug 16, 2025
8 checks passed
@rolandwalker rolandwalker deleted the RW/coerce-check-hostname-to-bool branch August 16, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants