Typehint completion_refresher.py
#1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d078199 to
a90c457
Compare
completetion_refresher.pycompletion_refresher.py
* add typehints * import annotations for Python 3.9 compatibility * remove OrderedDict as we no longer support old Pythons * correct "pgexecute" comment * reformat some long type signatures * bugfix: check that server_info is not None before invoking a method on it * force a list() on COMMANDS.keys() in completion_refresher.py * check type of func_data before calling extend() directly * set the empty string if set_dbname() is called with None * update the changelog to express that typehinting is mostly done
a90c457 to
9f79b06
Compare
amjith
reviewed
Jul 27, 2025
|
|
||
| class CompletionRefresher: | ||
| refreshers = OrderedDict() | ||
| refreshers: dict = {} |
Member
There was a problem hiding this comment.
Changing from OrderedDict to Dict didn't change behavior?
I'm trying to remember why this was an OrderedDict to begin with.
Contributor
Author
There was a problem hiding this comment.
It shouldn't change behavior because dict is ordered after Python 3.7. There are some small differences with OrderedDict per https://docs.python.org/3/library/collections.html#collections.OrderedDict , but one difference is that dict is supposed to be more performant for the common case.
amjith
approved these changes
Jul 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrderedDictas we no longer support old Pythonslist()onCOMMANDS.keys()incompletion_refresher.pyfunc_databefore callingextend()directlyset_dbname()is called withNoneChecklist
changelog.md.AUTHORSfile (or it's already there).uv ruff check && uv ruff formatto lint and format the code.