Improve feedback from running external commands #1249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amjith
approved these changes
Jul 5, 2025
* use click.secho() instead of print() * show STDERR output in red * add nonzero exit code message, in red We could consider showing diagnostic output in another color such as blue, but emphasizing the exit code message in red.
5e66f51 to
7eada18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
click.secho()instead ofprint()STDERRoutput in redWe could consider showing diagnostic output in another color such as blue, but emphasizing the exit code message in red.
Checklist
changelog.md.AUTHORSfile (or it's already there).