fix: implement Flusher interface for wrapped ResponseWriters #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danielgtaylor
approved these changes
Jan 13, 2023
Collaborator
|
On Fri, Jan 13, 2023 at 11:43 AM Daniel G. Taylor ***@***.***> wrote:
Merged #89 <#89> into main.
—
Reply to this email directly, view it on GitHub
<#89 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACK75ODYHPU3ADDHLVQ742LWSGV7XANCNFSM6AAAAAATWEE6RQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
A
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to address issue #88. As the standard library docs suggested, the problem is related to wrapping
ResponseWriterinstances. I went through and implemented aFlushmethod for thestatusRecorderandhuma.Contexttypes. I tested this with a resource handler that was generated server side events (i.e., calledctx.Write(...)multiple times invoking.Flush()after each). Runningcurl -N ...showed that the output was, in fact, getting flushed (which was definitely not the case before these changes).I haven't tested this with an SSE client, but just running
curl -Nseems like an adequate test of the functionality for now.